UpgradeManager: Get notified on serverMode changes - #961
Open
Ray Sun (FluoriteCafe-work) wants to merge 11 commits into
Open
UpgradeManager: Get notified on serverMode changes#961Ray Sun (FluoriteCafe-work) wants to merge 11 commits into
serverMode changes#961Ray Sun (FluoriteCafe-work) wants to merge 11 commits into
Conversation
`ready()` is idompotent and initializes `extensionApi`.
Ray Sun (FluoriteCafe-work)
marked this pull request as ready for review
January 27, 2026 08:36
Ray Sun (FluoriteCafe-work)
requested review from
Changyong Gong (chagong),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
January 27, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless other components in this extension,
UpgradeManagerdid not watchserverModechanges, and thus may fail to work under certain circumstances like race conditions or Java project configuration changes due to user action. This PR fills in the blank.(Note: this PR is written to be easier reviewable commit by commit.)